search

OffchainLabs / arbitrum-sdk

https://arbitrum-sdk.vercel.app
Apache License 2.0
233 stars 177 forks source link

`nativeTokenIsEth` logic fixed in `ParentToChildMessageCreator` #535

Closed tadad closed 3 weeks ago

tadad commented 1 month ago

addresses #534

cla-bot[bot] commented 1 month ago

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign one of the linked documents below to get yourself added. If you're an independent Individual please sign this form: https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=1353a816-a9c1-47ba-847e-ec79f0f23d31&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2. If you're with a company (corporate) please sign this form: https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=2b5fe8ba-51d4-4980-b4ee-605d66e675d4&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2. To agree to the CLA license, please fill out one of the attached forms.

hkalodner commented 1 month ago

@cla-bot check

cla-bot[bot] commented 1 month ago

The cla-bot has been summoned, and re-checked this pull request!

spsjvc commented 3 weeks ago

Hey @tadad, thank you for the contribution!

I'll have to close this PR in favor of https://github.com/OffchainLabs/arbitrum-sdk/pull/541 since we want to have the same fix in both v3 and v4.