arb-deploy dev-mode improvements - Githubissues

OffchainLabs / demo-dapp-pet-shop

Pet shop dapp, for use as an Arbitrum demo

Apache License 2.0

20 stars 10 forks source link

arb-deploy dev-mode improvements #2

Closed ughe closed 5 years ago

ughe commented 5 years ago

Changes:

Runs in --dev-mode automatically if compose folder exists or flag
Does not run now if the build fails
Halt docker-compose immediatley instead of waiting default 10 seconds
Kills and rms all arb-validator and arb-ethbridge containers
Removed all interactive prompts
Warms arb-validator build cache in dev-mode by running go mod vendor on host
Builds arb-validator dev-mode.Dockerfile by replacing all ##DEV_ with
Added pre commit hooks to dev-mode golang repos for go fmt and replace rules
Pinned normal mode git clones to release branch versions
Added -b or --build flag to just build and not run
Renamed --dev flag to --dev-mode

ughe commented 5 years ago

Improvements:

Run all bash commands with shell=True equivalent
Halt if any command has non-zero exit status, except for commands that kill docker
Fixed awk command must have single quotes
Added Apache 2.0 License header
Run yarn in provider repos (didn't happen before) and symlink in ethers into web3