search

OffchainLabs / eth-pos-devnet

MIT License
103 stars 124 forks source link

Using 'latest' for a few of docker images #56

Open wawrzek opened 1 month ago

wawrzek commented 1 month ago

Using the 'latest' tag in a docker image definition is a dangerous practice, especially if the that can point at unstable images. That's the case for both the 'geth' and the 'prysmctl' images.

The recent problem with prysmctl, related to inclusion of incoming Electra work, was mentioned in #55 or #49, but there are more example of user hitting unstable image (e.g. #41).

One of the recent changes to geth caused the Failed to get EIP-1559 fees issue (https://github.com/ethereum/go-ethereum/issues/29898). I also notice problems similar to https://github.com/ethereum/go-ethereum/issues/29880.

The solution is to lock the version of all images (at least the ones not using the stable tag).

wawrzek commented 1 month ago

Example of a fix: https://github.com/ivy-net/eth-pos-devnet/pull/2