search

OffchainLabs / go-ethereum

GNU Lesser General Public License v3.0
54 stars 94 forks source link

Implement more complex slot value comparisons #269

Closed diwu1989 closed 9 months ago

diwu1989 commented 10 months ago

Add an optional SlotValueComparison to support =,!=,>,< value comparisons in conditional TX. The current equality check is not sufficient for detecting specific kinds of value changes in a slot value.

cla-bot[bot] commented 10 months ago

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

cla-bot[bot] commented 10 months ago

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

hkalodner commented 10 months ago

@cla-bot check

cla-bot[bot] commented 10 months ago

The cla-bot has been summoned, and re-checked this pull request!

joshuacolvin0 commented 9 months ago

The only reason eth_sendRawTransactionConditional exists is to provide compatibility with account abstraction bundlers. The implementation follows the API designed for any L2, and is described here: https://notes.ethereum.org/@yoav/SkaX2lS9j

The functionality is limited on purpose to reduce DOS risk.