search

OffchainLabs / go-ethereum

GNU Lesser General Public License v3.0
54 stars 94 forks source link

Revert "core/state: mark account as dirty when resetObject occurs" #271

Closed PlasmaPower closed 9 months ago

PlasmaPower commented 9 months ago

This reverts commit 15bd21f3c878155bc2254bb43460763298f58ad1.

This worked for upstream go-ethereum, but some ways we manipulate the state means this changes behavior for us

tsahee commented 9 months ago

seems fine.. but need to understand that test failure (I re-ran it to see if it's just flakiness)

PlasmaPower commented 9 months ago

Hmm yeah this seems to have broken something. I'll take a look tomorrow

PlasmaPower commented 9 months ago

The failing test is in state_fuzz_test.go and they say "We're mostly adding this change to appease the fuzzer" so I think it might be intended and we should just disable that test.

PlasmaPower commented 9 months ago

I've skipped that test. I've been syncing a node overnight with this change and it agrees with the rest of the network, so I think it's working (definitely working better than the previous alpha).