Closed Tristan-Wilson closed 3 months ago
We're discussing if we want to increase the metrics count by so much; I'll fix the tests if we decide to go ahead with it.
We think this will increase the number of metrics too much, we'll just use the prometheus rate feature to post-aggregate instead.
The RateX() fields were not being collected.
Testing done
Prior to the change, the only metric is
compact_time
for the prometheus endpoint:After the change, there is a
compact_time
metric shown with labels for each of the rates and there is also acompact_time_count
metric which just has the count.This would add an extra 740 metrics to the prometheus endpoint for Nitro which uses go-ethereum, on top of the existing 687.