ganeshvanahalli commented 5 months ago

Upstream disabled logging by default, but we keep it on since the logs are very useful for tests in nitro
This PR in upstream geth introduces a deadlock when using simulated_beacon_api with multiple transactions being submitted simultaneously (an often situation in multiple nitro tests). We also include a fix for this
- The api in simulator mode, eventually calls forced reset on txpool, and that calls each of the subpools to notify its subscribers (which is blocking) with transactions that were affected by the reset, and the api is one of the subscribers- thus a deadlock :)
- The fix is to make the txEvents channel that api uses a buffered one, here we choose the capacity to be 15 (which is ample for situations handled in nitro tests)
On M2 mac, metrics/influxdb/ tests fail due to different floating point results

Testing done

geth and nitro tests pass

cla-bot[bot] commented 5 months ago

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

cla-bot[bot] commented 5 months ago

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

cla-bot[bot] commented 5 months ago

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

OffchainLabs / go-ethereum