Closed ashleydraper closed 1 year ago
Looks good to me. @artuoma
@ashleydraper what roles option should we include in the select box?
@carterm could you add azure post service to this one?
@kkoryaka Let use this list:
@carterm I have invited you to the OET research Airtable account for testing and configuration. Please let me know if you need further access or if you run into issues with your research.
https://airtable.com/appu01tGlmTTMm5uX/tblN7oCcLMOSPvbM6/viwBA9aiJfgaPQzga?blocks=hide
cc @artuoma @kkoryaka @ashleydraper
@carterm See below for form setup in airtable. I added the field values to the table for you and a link to review Design System feedback form configuration here: https://airtable.com/app4B5KqaCTSHAdCS/tbliV5kSgz7jBnIyT/viwDkwTUo3wZOqYhF?blocks=hide
State Template contact form responses
Review Design System feedback form configuration
cc @kkoryaka @artuoma @extinah
@yesenia-gtz The link above does not work for me.
Sorry, the page you were looking for was not found
@carterm bummer, it is a link to the screenshot I attached for Review Design System feedback form configuration. just wanted to show you what was done in the Automations area of airtable.. you should be able to do that in our database.
@extinah @sharon-rabang is there a design for the contact page ? are we using a generic form layout for this?
@yesenia-gtz It existed on the last board, I just copied it to our new environment. Here's the contact us design from Courtney. Sharon may want to redesign.
@yesenia-gtz @ashleydraper @extinah @carterm Here is the redesigned form in Figma: Contact us | Contact us error messages Please let me know if we'll need to make any changes. Thanks!
@hamiltonryan @artuoma @kkoryaka @extinah should we include a section for Department in the contact form? Would be great to know who is reaching out to keep track of interested persons.
@yesenia-gtz Carter asked to move this item to production release date instead of Nov 4, because a lot of research involved.
Moved to production release
Updated the word doc to include a section for department.... then saw this was moved to production release. Heads up.
https://docs.google.com/document/d/1pGl4gHz1IX8Kn94GQXWUzbHGInjf5f-c08TejsBlquc/edit
@hamiltonryan @artuoma @kkoryaka @extinah should we include a section for Department in the contact form? Would be great to know who is reaching out to keep track of interested persons.
I think we should do this.
Meeting with DevSecOps to set up Azure environment to run the Contact Us service.
The plan is to create a Azure FaaS endpoint in Node.JS that will act as a middle tier between the public website and the AirTable Base. The endpoint will only allow requests from specific origins, and only add new records to AirTable. The code for the endpoint will be created in a way that encourages users of the State Template to set up their own endpoints.
This is the service created to support the data flow.
https://github.com/Office-of-Digital-Services/cagov-form-post-service
Working with DevSecOps to set up the environment. It's a first time setting up an Azure Function with the current pipelines. Working through it, we got the service running, but they will need to recreate some Azure components for the final setup that won't be done until after Thanksgiving.
PR for working release... https://github.com/Office-of-Digital-Services/California-State-Web-Template-Website/pull/878
deployed to staging.
https://as-cdt-pub-migr-betaws-ww-p-001-stage.azurewebsites.net/contact-us-form.html
@carterm OK to move to UX design review?
Added cosmetic updates to better match Figma design... https://github.com/Office-of-Digital-Services/California-State-Web-Template-Website/pull/879
@yesenia-gtz - deploying one more update. I'll let you know.
Ok staging is ready for UX review.
@extinah ready for ya!
https://as-cdt-pub-migr-betaws-ww-p-001-stage.azurewebsites.net/contact-us-form.html
Do we have CSS styling for HTML5 "required" fields? The Figma design has glyphs etc, but that sort of convention should probably be included in the global CSS.
<style type="text/css">
input:required:invalid, input:focus:invalid {
background-image: url(/images/invalid.png);
background-position: right top;
background-repeat: no-repeat;
}
input:required:valid {
background-image: url(/images/valid.png);
background-position: right top;
background-repeat: no-repeat;
}
</style>
Also, our convention has required "*" in front of the label, and a "This field is required" label warning below, without entry instructions. In keeping with the convention, I went with what was on our form elements page.
https://beta.template.webstandards.ca.gov/components/form-elements.html
"Instructional, error messages, and placeholder text should not provide the same message as the label."
We should specs for interactions here. We'll try to get that to you sooner than later.
Adding accessibility update... https://github.com/Office-of-Digital-Services/California-State-Web-Template-Website/pull/880
Validators don't display until first submit attempt. https://github.com/Office-of-Digital-Services/California-State-Web-Template-Website/pull/883
@carterm here's some initial QA. NICELY DONE by the way. Yay :)
@sharon-rabang @ashleydraper can you both help finalize QA next week?
QA Only these two fields are required (name and email) per the design. I'm suggesting we make "How can we help" required, too.
Error messages if not submitting a required field:
Main role
Design
In dev: unselected: Selected:
I can certainly change the required fields.
I'm not sure I understand the problem with the "Main role" selection. It has a dropdown of suggested items, with the ability to type anything instead of selecting other (like a combo box). Also, the screen reader support correctly describes the field as allowing in-line or list entry.
The AirTable data design only has one field for "Role", no "Other" catch field.
I could limit the "Main role" selection to the list and then have a secondary field in for a "other" type in, but that appears confusing and redundant in my opinion.
Changing required fields and visual 2/3 formatting... https://github.com/Office-of-Digital-Services/California-State-Web-Template-Website/pull/891
Changing field width to less that 100% https://github.com/Office-of-Digital-Services/California-State-Web-Template-Website/pull/896
@carterm Thanks for making the field adjustments! To help you follow @extinah's initial QA comments above, here are the related design specs and callouts. Please make these design fixes to match the Figma prototype: Contact us error messages Let us know if we can help with any questions and when the updates are ready for UX review, thanks!
@kkoryaka Any idea on what css classes to change to make this work?
Adding captcha support...https://github.com/Office-of-Digital-Services/California-State-Web-Template-Website/pull/920
@sharon-rabang: The design is a little wrong - only 3 fields are required. The other ones (main role, department) shouldn't have error messages. The only one is maybe for department if they put in something into the field they shouldn't or there's too many characters. We can chat more about the specs later today (I'll call you). cc: @carterm PS: Sorry so late - it's taken me 2 days to get through all my git notifications :)
Per our team sync this morning: @ashleydraper will work on:
I (@extinah) will work on the form details (error messages, field details, etc). Will work with UX team for input, and then @carterm and @kkoryaka for initial dev feedback. Then a quick review with Kon, @artuoma, and @rkojik .
cc: @yesenia-gtz
Looking like a meeting is not necessary. Team agreed to use main contact us page to house the form.
@carterm Here is the content for the submitted feedback form.
We are deleting the current contact page (pictured) and replacing with content in this contact us doc. See edits in the document.
Per our team sync this morning: @ashleydraper will work on:
- the confirmation page text. When drafted, send to Kon, Art, Koji, and myself for review. When approved, I'll add it to figma and then let carter/devs know.
- Looking to see if the form can be on the main contact us page. Set up a meeting with the UX team after an initial draft/recommendation.
I (@extinah) will work on the form details (error messages, field details, etc). Will work with UX team for input, and then @carterm and @kkoryaka for initial dev feedback. Then a quick review with Kon, @artuoma, and @rkojik .
cc: @yesenia-gtz
@carterm Let's wait to make the changes until it's reviewed (or not close the ticket until then). Or feel free to make the content changes, but know there could be some edits. Thanks!
The contact us page is ready for review. Sending to leads.
Also sharing the feedback page for review.
I made one small comment. Approved by me, thanks.
@ashleydraper @extinah my review is complete, no additional feedback. Thank you!
Create a Contact Us page for the state template and track copy edits in this google doc.
Figma links: Contact us | Contact us error messages