OfficeDev / Copilot-for-M365-Samples

Microsoft Copilot for Microsoft 365 samples
https://aka.ms/extendcopilotm365
MIT License
117 stars 79 forks source link

[Bug]: Need to implement Refresh - chokes on them now and they are appearing in some env'ts #114

Closed BobGerman closed 2 months ago

BobGerman commented 4 months ago

Sample

msgext-northwind-inventory-ts

Description

@therealjohn observed errors when placing the adaptive card We are suddenly receiving Refresh activities. Workaround is to return status code 200 instead of 400 on line 55 of searchApp.ts. This issue should be resolved properly and we should actually refresh the card when we get these.

Steps to reproduce

Place a card in chat via the ordinary ME interface You will see an error on the bottom of the card. This is due to the refresh failure.

Expected results

Card should not show an error

Actual results

Card shows an error

Additional Info

No response

BobGerman commented 4 months ago

UPDATE: This PR contains the workaround: https://github.com/OfficeDev/Copilot-for-M365-Plugins-Samples/pull/115 Keeping this issue open so we properly implement Refresh activity handling in the future...

@rabwill @garrytrinder

garrytrinder commented 2 months ago

Closing issue as #115 has been merged