Update SSO code to leverage BotFramework Cache

OfficeDev / Microsoft-Teams-Samples

Welcome to the Microsoft Teams samples repository. Here you will find task-focused samples in C#, JavaScript and TypeScript to help you get started with the Microsoft Teams App!

MIT License

997 stars 770 forks source link

Update SSO code to leverage BotFramework Cache #1015

Closed ericsche closed 10 months ago

ericsche commented 11 months ago

We should change the code here to leverage the Bot Framework Token Cache, it will improve performance and avoid some issues in corner cases.

The auth card type should be silentAuth and not auth

https://github.com/OfficeDev/Microsoft-Teams-Samples/blob/main/samples/app-sso/csharp/App%20SSO%20Sample/Bots/TeamsMessagingExtensionsSearchAuthConfigBot.cs

microsoft-github-policy-service[bot] commented 11 months ago

Hi @ericsche! Thank you for bringing this issue to our attention. We will investigate and if we require further information we will reach out in one business day. Please use this link to escalate if you don't get replies.

Best regards, Teams Platform

SaiPratap-MSFT commented 11 months ago

@ericsche - Thanks for raising this, we will check this with concerned team and will get the code updated.

PR has raised for this issue: https://github.com/OfficeDev/Microsoft-Teams-Samples/pull/1047 We will merge the PR and let you know.

Update: PR is merged now.

We are closing this issue for now, please feel free to reopen it, if required.

microsoft-github-policy-service[bot] commented 10 months ago

Tell us about your experience!

Hi @ericsche! This issue is closed in our system. We would like your feedback on your experience with our support team and Platform.

Best regards, Teams Platform