search

OfficeDev / Microsoft-Teams-Samples

Welcome to the Microsoft Teams samples repository. Here you will find task-focused samples in C#, JavaScript and TypeScript to help you get started with the Microsoft Teams App!
MIT License
949 stars 749 forks source link

Incorrect response type used in nodejs `bot-sso-adaptivecard` sample #1086

Open garrytrinder opened 8 months ago

garrytrinder commented 8 months ago

The nodejs bot-sso-adaptivecard sample uses the incorrect type in it's response.

https://github.com/OfficeDev/Microsoft-Teams-Samples/blob/e834610aee96adf3c1dbe6d1dfcbda38f43b300f/samples/bot-sso-adaptivecard/nodejs/bots/botSSOAdaptiveCard.js#L184-L188

It should be 

var loginReqResponse = {
    StatusCode: 401,
    Type: "application/vnd.microsoft.activity.loginRequest",
    Value: oAuthCard
}
Meghana-MSFT commented 8 months ago

Thank you for reporting this, we will check this and get back to you.

Update: We are looking into it and let you know the updates.

simone-montemezzani-3AP commented 4 months ago

Any news on this? Sample still contains application/vnd.microsoft.card.loginRequest.