OfficeDev / Microsoft-Teams-Samples

Welcome to the Microsoft Teams samples repository. Here you will find task-focused samples in C#, JavaScript and TypeScript to help you get started with the Microsoft Teams App!
MIT License
898 stars 725 forks source link

OAuth not properly handling response #1309

Open diegoriera opened 1 week ago

diegoriera commented 1 week ago

https://github.com/OfficeDev/Microsoft-Teams-Samples/tree/main/samples/bot-teams-authentication/python

This sample is not properly handling response received after OAuth.

image

Prasad-MSFT commented 1 week ago

@diegoriera - Thanks for raising your issue. We will check this at our end and will update you accordingly.

Prasad-MSFT commented 1 week ago

@diegoriera - We tried to repro this issue with the provided sample and observed that it works as expected.

image image

diegoriera commented 1 week ago

You used SSO, to reproduce it use OAuth as described on this document https://learn.microsoft.com/en-us/microsoftteams/platform/bots/how-to/authentication/add-authentication?tabs=dotnet%2Cpython-sample

Prasad-MSFT commented 1 week ago

After using OAuth we are also encountering same issue.

image

image

image

Error in console:

{
    "errorCode": 1008,
    "message": "<BotError>Agent returned unsuccessful status code NotImplemented",
    "standardizedError": {
        "errorCode": 1008,
        "errorSubCode": 1,
        "errorDescription": "<BotError>Agent returned unsuccessful status code NotImplemented"
    }
}

Please let us know if you are encountering the same. Accordingly, we will discuss this internally and will get back to you.

diegoriera commented 1 week ago

Yes, this is the exact behavior

bogdanbujdea commented 3 days ago

I'm having the same issue. When I test the connection from Azure I get the token, but it doesn't work from my bot. image

{ "errorCode": 1008, "message": "<BotError>Agent returned unsuccessful status code NotImplemented", "standardizedError": { "errorCode": 1008, "errorSubCode": 1, "errorDescription": "<BotError>Agent returned unsuccessful status code NotImplemented" } }

Prasad-MSFT commented 1 day ago

We are able to repro this issue. We have raised a bug for the same. We will inform you once we get any further update from engineering team. Thanks!