Open blackchoey opened 4 months ago
microsoft-github-policy-service[bot]
commented
4 months ago Hi @blackchoey! Thank you for bringing this issue to our attention. We will investigate and if we require further information we will reach out in one business day. Please use this link to escalate if you don't get replies.
Best regards, Teams Platform
Nivedipa-MSFT
commented
4 months ago @blackchoey - Thanks for reporting your issue. We are not quite clear on your issue, could you please provide more details on your issue? As per our understanding in order to send proactive messages using bot, AAD app is required. right?
Nivedipa-MSFT
commented
4 months ago @blackchoey - Could you please provide more details on your issue to investigate further?
blackchoey
commented
4 months ago @Nivedipa-MSFT The sample does not need this step: https://github.com/OfficeDev/Microsoft-Teams-Samples/blob/main/samples/bot-proactive-messaging-teamsfx/teamsapp.yml#L13-L25. I'm suggesting to remove this step to avoid possible confusions. There's customer asking why this sample need to create that AAD app.
Nivedipa-MSFT
commented
4 months ago @blackchoey - We have informed this to the sample team. PR will be raised to make necessary changes.
Nivedipa-MSFT
commented
2 months ago @blackchoey - PR has merged. Could you please check and let us know if you have any query here.
The https://github.com/OfficeDev/Microsoft-Teams-Samples/tree/main/samples/bot-proactive-messaging-teamsfx sample seems not calling external APIs in the code. So it does not need an AAD app. Below step in
teamsapp.ymlandteamsapp.local.ymlcould be removed to avoid creating an AAD app. https://github.com/OfficeDev/Microsoft-Teams-Samples/blob/main/samples/bot-proactive-messaging-teamsfx/teamsapp.yml#L13-L25 Other AAD app related content like the AAD app manifest also needs to be removed.