search

OfficeDev / Microsoft-Teams-Samples

Welcome to the Microsoft Teams samples repository. Here you will find task-focused samples in C#, JavaScript and TypeScript to help you get started with the Microsoft Teams App!
MIT License
945 stars 745 forks source link

bot-conversation-sso-quickstart csharp version has build errors #1326

Open appieschot opened 1 month ago

appieschot commented 1 month ago

When pulling in the csharp version of the bot-conversation-sso-quickstart available at: https://github.com/OfficeDev/Microsoft-Teams-Samples/tree/main/samples/bot-conversation-sso-quickstart/csharp_dotnetcore/BotConversationSsoQuickstart

The F5 experience does not work due to a missing file (or wrong filepath depending on your take).

The build experience uses the file BotConversationSsoQuickstart\teamsapp.local.yml to run. That file contains teamsApp/validateManifest that refers to the following: 

  - uses: teamsApp/validateManifest
    with:
      # Path to manifest template
      manifestPath: ./AppManifest/manifest.json

That file path does not exist, it most likely must point to ../TeamsApp/appPackage/manifest.json

The same is for all following steps:

Happy to create a pull request with changes if we agree on that approach.

appieschot commented 1 month ago

In addition, the manifest.json in the /TeamsApp is working properly, I assume you could also safely remove the infra and teamsapp.yml files from the BotConversationSsoQuickstart project.

Meghana-MSFT commented 1 month ago

@appieschot - Thank you for reporting this, we have informed this to the sample team. PR will be raised to make necessary changes.

Update: PR https://github.com/OfficeDev/Microsoft-Teams-Samples/pull/1327 has been raised and merged for above issue.