OfficeDev / Microsoft-Teams-Samples

Welcome to the Microsoft Teams samples repository. Here you will find task-focused samples in C#, JavaScript and TypeScript to help you get started with the Microsoft Teams App!
MIT License
1.04k stars 789 forks source link

Deep link generated by a tab not working (C#) #1399

Open pankajmunde12 opened 2 months ago

pankajmunde12 commented 2 months ago

Hi Team, I am testing tab-request-approval sample (C#). When a tab sends an activity notification, the recipient user gets the message in activity section of the MS Teams. When the user clicks on the notification, following message is being displayed: This app cannot be found. Please see the below screenshot for more details. Could you please check this and see if there is any error in generating the deep-link?

Kind regards, Pankaj Munde

tab-request-approval-error

Prasad-MSFT commented 2 months ago

Thanks for raising your issue. We will check this at our end and will update you accordingly.

Prasad-MSFT commented 2 months ago

Hi @pankajmunde12, the app should be installed for user's manager also to get task approval notification. Could you please verify that?

We tried this at our end and upon getting notification and clicking on it, its redirecting us to appropriate place to approve/reject the request. image

pankajmunde12 commented 2 months ago

Ok. Thanks @Prasad-MSFT ! Let me check and confirm.

pankajmunde12 commented 2 months ago

Hi @Prasad-MSFT Thanks for your suggestion. But I figured out that it was a problem with deep-link creation logic. I have created a pull request for it. Could you please check it once? https://github.com/OfficeDev/Microsoft-Teams-Samples/pull/1402

Thanks, Pankaj