OfficeDev / Microsoft-Teams-Samples

Welcome to the Microsoft Teams samples repository. Here you will find task-focused samples in C#, JavaScript and TypeScript to help you get started with the Microsoft Teams App!
MIT License
955 stars 755 forks source link

tab-device-permission Capture audio + capture video doesn't work in the desktop client #715

Open eoinobrien opened 1 year ago

eoinobrien commented 1 year ago

Hi, the media capabilities don't seem to be working when I try them in a desktop client.

They work in a browser but that uses a different set of code.

I get the following error when I click "Capture Audio": image

And when I click "Capture Video" I don't see an error but the video isn't captured, and the following error is shown in the devtools console: image

Here are my client details

 "ring": {
    "id": "ring3_6",
    "friendlyName": "Public Developer Preview (R3.6)",
    "friendlyShortName": "P",
    "shortName": "R3.6",
    "isPublic": true,
    "eTag": "\"0gFSTWSpejjssmJw3nS7iMotNLU1PKcGy5SJfCAAsdA=\"",
    "configIds": "<snipped>"
  },
  "sessionId": "<snipped>"
  "cdlWorkerSesionId": "<snipped>",
  "timezone": -5,
  "version": {
    "buildDate": "2023-02-14T00:39:26.512Z",
    "versionDate": "2023-02-14T00:00:53.000Z",
    "versionHash": "c4b0c61f7b311e9055e9a98713c062b284c31b5a",
    "clientVersion": "27/1.0.0.2023021323",
    "semver": "1.0.2023021323",
    "tsCallingVersion": "2023.5.01.8",
    "slimcoreVersion": "2023.05.4"
  },

Also I am confused by a bit of the structure of the code. From looking at the names of the components, I would assume CaptureAudioDesktop, CaptureVideoDesktop etc are the components that are run in the desktop client, when instead they are the components used in the web client. Is is possible to rename to make this easier?: image

Prasad-MSFT commented 1 year ago

@eoinobrien - Thanks for raising the issue. We will check this at our end and revert back with updates. Thanks!

Prasad-MSFT commented 1 year ago

@eoinobrien - We are also able to repro the issue and getting same errors as you got in MS Teams desktop client Microsoft Teams Version 1.6.00.4378 in R3.6.

We are checking this with concerned team and will update the sample with necessary changes.

Prasad-MSFT commented 1 year ago

@eoinobrien - Changed the components names as suggested using this merged PR and regarding functionality not working in desktop client, team is following with engineering team regarding the supportability and will make necessary changes after analysis.

Prasad-MSFT commented 1 year ago

Update: For Capture audio + Capture video functionality not working for Teams desktop client, we have raised a bug and assigned it to engineering team for further investigation. We will inform you once we have any update. Thanks!

Prasad-MSFT commented 1 year ago

Engineering team is analysing the bug. Currently there is no ETA to share. We will inform you once we have any update. Thanks!