OfficeDev / O365-EDU-Tools

O365 Education tools and scripts repository
MIT License
202 stars 396 forks source link

Specified modifications are done in Canvas ADF template #130

Closed bramchandram closed 1 month ago

bramchandram commented 3 months ago
bramchandram commented 3 months ago

Mentioned changes are done Ayron. Line 4346: The resource name should be unique, so I kept it as 'kvcanvassdsadf'. The instruction document is being prepared. Once it is completed, I will let you know.

bramchandram commented 2 months ago
  1. Changed the resource parameter names to generic names as follows for easier identification. "vaults_key_canvas_sds_name" to "Key vault name", "storageAccounts_stcanvassds_name" to "Storage account name", "dataFactoryName" to "Data Factory name".
  2. And I changed a few parameters to variables to hide them on the deployment page. Now, we can only see the resource parameters and global parameters on the deployment page, which are required to be entered by the customer.
  3. The Solution document was uploaded as well.
AyronJohnson commented 2 months ago

@bramchandram Please see comments in the word doc. Also, replace the word doc with a pdf after making the changes. We can keep the word version in the sharepoint location

bramchandram commented 2 months ago

The changes mentioned are now in place and the document has been uploaded in PDF format. Please check it once and let us know if any changes are required.