search

OfficeDev / O365-InvestigationTooling

MIT License
574 stars 361 forks source link

Fixes for mailbox auditing #57

Closed 007 closed 5 years ago

007 commented 5 years ago
msftclas commented 5 years ago

CLA assistant check
All CLA requirements met.

007 commented 5 years ago

@o365devx @bkoeller bump so this doesn't languish for 5 quarters like previous PRs

007 commented 5 years ago

Another month, another bump!

PsychoData commented 5 years ago

I've about given up on these actually getting reviewed and merged. You would think that f they didn't want things submitted they would change it so you couldn't submit and then sign the CLA

There are loads of people who have submitted commits to fix the dang RedirectsTo to RedirectTo like it should be so it ACTUALLY works been sitting for over a year or longer

On Mon, Jun 3, 2019 at 12:48 PM Ryan Moore notifications@github.com wrote:

Another month, another bump!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/OfficeDev/O365-InvestigationTooling/pull/57?email_source=notifications&email_token=AA4L7THWXERH4ZAR7Y4VX63PYVDMFA5CNFSM4HIP7JA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW2AFTQ#issuecomment-498336462, or mute the thread https://github.com/notifications/unsubscribe-auth/AA4L7TCRBQKB4TCLXKPKXZDPYVDMFANCNFSM4HIP7JAQ .

007 commented 5 years ago

Another month, another bump redux.

Adding @davidchesnut as the only other minor contributor / $MSFT org member that might have context and might care to take action here.

arjancornelissen commented 5 years ago

I wouldn't do line 23, removing the out-gridview. Checking large sets of mailboxes will not work in the normal output. Get-mailbox should be placed in a variable and have a select-object DistinguishedName

007 commented 5 years ago

Out-GridView doesn't exist in PS6 so it makes sense to remove that until it comes back in a later dot-revision or in v7. The commit message doesn't explain as it should have, that's why I included pseudo-deprecated output filter in the pull description.

You should submit a PR to address the second half of your comment if that's a more standard / accepted convention, this was my first encounter with PowerShell so my code is definitely less than ideal.