OfficeDev / Office-365-SDK-for-Android

Microsoft Services SDKs for Android produced by MS Open Tech.
https://dev.office.com/android
Other
224 stars 74 forks source link

Simple Exchange Sample does not need createEncryptionKey #50

Closed davidchesnut closed 9 years ago

davidchesnut commented 9 years ago

The Simple Exchange Sample has two methods in the Authentication class; createEncryptionKey and getEncryptionKey. They create and store an encryption key which is apparently never used. I recommend removing these methods as they make the Authentication class appear more complex than it actually is.

marcote commented 9 years ago

@davechmsft The Authentication class is simply a Helper class to ease developers the interaction with the ADAL library. In older and more complex examples we used to use mentioned methods. I will review if we can remove them.

marcote commented 9 years ago

We removed this functionality this code. Users should refer to ADAL if they want to handle this scenario.