OfficeDev / Office-365-SDK-for-iOS

Microsoft Services SDKs for iOS Preview produced by MS Open Tech.
https://dev.office.com/
Other
96 stars 49 forks source link

ADALiOS update failure to 1.2.9 version #105

Open ajitkumar1 opened 8 years ago

ajitkumar1 commented 8 years ago

My native iOS app connects to office 365 through ADALiOS. Currently it is using ADALiOS 1.2.4 and Office365 0.11.0. With the new iOS 10 update the log in to office 365 is not working. So ADAL is recommending to update the library to 1.2.9

Below is the pod file which i am using to update

``pod 'Office365', '~>0.11.0' pod 'ADALiOS', '~>1.2.9'

target 'Compen10' do

end``

With this the 'pod update' command throwing below

[!] Unable to satisfy the following requirements: ADALiOS (~> 1.2.9) required by Podfile ADALiOS (~> 1.2.9) required by Podfile ADALiOS (= 1.2.4) required by orc (0.2.0)

michalcichon commented 8 years ago

The same problem here. This is weird because if I set:

pod 'Office365'
pod 'ADALiOS', '~> 1.2.9'

Then cocoapods install Office365 in version 0.9.0. I was using 0.9.1 since now and it was needed for Office 365 snippets, but snippets don't work with the older version.

Why ADALiOS is downloaded with Office365 version 0.9.0 but not for higher versions like 0.9.1 and 0.11.0?

michalcichon commented 8 years ago

I solved problem with dependency by creating own fork of the Office365 (I defined the dependency to ~> 1.2 in it), but ADALiOS still fails with 3072 error.

ghost commented 6 years ago

Im facing same issue. I get authentication error in IOS 10 but it works in 9. Where you able to solve it?

michalcichon commented 6 years ago

Hi @vergel

I created my own patch for this issues.

pod 'ADALiOS', :git => 'https://github.com/michalcichon/azure-activedirectory-library-for-objc', :commit => 'd16768400a7532cdd4b4bf7dd52ebb0fb92c626a' #'~> 1.2.9'
pod 'Office365', :git => 'https://github.com/michalcichon/Office-365-SDK-for-iOS.git', :commit => '0f9879d928f67159a330324de6659c9e48bf3208'
michalcichon commented 6 years ago

My fix to 0.9.1 version is available here: https://github.com/michalcichon/Office-365-SDK-for-iOS/tree/0.9.x

But I cannot create a pull request because there is only master and dev branches in the project but no separate branches to each version.

ghost commented 6 years ago

Thanks michal. My app now works on IOS 10 and 11.

ghost commented 6 years ago

I'm getting an error "Invalid JSON. A comma character ',' was expected in scope 'Object'. Every two elements in an array and properties of an object must be separated by comma.". This happens when I update a calendar event using the Office365Snippets. Any idea what's wrong ?