Closed jfoclpf closed 1 year ago
Just to be sure, I just tried now with node v14.18.0
and v16.14.0
and I get the same error
We have the same error with our manifest as well. I am not going to publish it as it is similar to the manifest posted. The main point it uses the Extention point "Event". Please note, the manifest still can be installed onto O365 mailbox.
Add-ins with On-Send events are not allowed on the add-in store. They can only be installed by the organization admin or manually.
Add-ins with On-Send events are not allowed on the add-in store. They can only be installed by the organization admin or manually.
I am installing it manually.
But the main point is: why is office-addin-manifest validate
throwing an error when the manifest is totally valid?
I would like to add to the point. What is office-addin-manifest
validation tool? Is this tool which validates manifest against of requirements of the Office store or the tool which validates against all known VersionOverrides schemas? As the developer, I would be interested if my manifest validated against all schemas. If I will submit my manifest to the Office store, they will provide me with detailed results and I will react accordingly. Even a better idea to have your tool the command line switch to do the full validation or validation for the Office store.
The tool does the same validation as the add-in store minus the dev inner loop urls (full store validation would flag the use of 'localhost'). If some things are not allowed in the store but are allowed locally (other than 'localhost'), then it's going to flag those. It would be a nice feature add to be able to designate which type of validation to do.
@jfoclpf We have updated the documentation accordingly. Kindly refer to https://docs.microsoft.com/en-us/office/dev/add-ins/testing/troubleshoot-manifest
Nice, I realise now we may use an extra -p
option when we want to validate for the store
npx office-addin-manifest validate -p MANIFEST_FILE
But now I have a question: you mention xmllint
to validate against the xml schema. But office-addin-manifest
does not do that also already?
@millerds Can you please answer above follow-up query from @jfoclpf ? Thanks.
The tool calls a service endpoint (which is also used by the store) and we just report the results . . . I do not know the details of how it validates the manifest.
I mean, the manifest already provides the schema, for example at http://schemas.microsoft.com/office/appforoffice/1.1
I was wondering if office-addin-manifest validate
would already do that without the need of xmllint
I get that . . . but it would be up to the service we call to take care of that as it is not something directly done in the tool (which just reports the service call results).
I get the same error when I validate it. The problem for me is that, I am able to sideload the addin using manifest.xml manually but the same xml when deployed using Microsoft Admin Console says "invalid manifest file" like below.
Is there any way to know what the exact problem is ?
I get the same error when I validate it. The problem for me is that, I am able to sideload the addin using manifest.xml manually but the same xml when deployed using Microsoft Admin Console says "invalid manifest file" like below.
Is there any way to know what the exact problem is ?
The validation error from command (npm run validate) is
Mailbox add-in containing ItemSend event is invalid.: Mailbox add-in containing ItemSend event is invalid. (link: undefined)
- Details: Mailbox add-in manifest contains ItemSend event in VersionOverrides which is not allowed.
When we added below fields, the addin was loaded successfully from Microsoft Admin Console in spite of validation failure.
<IconUrl DefaultValue="https://icons.iconarchive.com/icons/ampeross/qetto/64/icon-developer-icon.png"/>
<HighResolutionIconUrl DefaultValue="https://icons.iconarchive.com/icons/ampeross/qetto/128/icon-developer-icon.png"/>
<SupportUrl DefaultValue="https://docs.microsoft.com/office/dev/add-ins/overview/office-add-in-code-samples"/>
Looks like the main issue has been explained. If there is a feature suggestion for the tools, please suggest (and up vote) at https://aka.ms/M365dev-suggestions
Expected behavior
This valid manifest file taken by your example should be correctly validated by
office-addin-manifest validate
.ItemSend event is valid inside VersionOverrides.
Current behavior
It's throwing an error:
Steps to Reproduce
manifest_dev.xml
npx office-addin-manifest validate manifest_test.xml
Context
In the context of creating an ItemSend Event for an Outlook Appointment.
Failure Logs
We are using this manifest which also fails with
Mailbox add-in manifest contains ItemSend event in VersionOverrides which is not allowed.