search

OfficeDev / Office-Addin-Scripts

A set of scripts and packages that are consumed in Office add-ins projects.
MIT License
159 stars 100 forks source link

office-addin-manifest validation fails with 502 #687

Closed wh1t3cAt1k closed 1 year ago

wh1t3cAt1k commented 2 years ago

https://validationgateway.omex.office.net/package/api/check?clientId=Default

image

wh1t3cAt1k commented 2 years ago

On a side note, can the error be made more specific so we can catch it properly?

image

"Unexpected token <" is too cryptic, I thought that there was something wrong with our manifest; I'd expect a more descriptive error message about the validation service not being accessible.

millerds commented 2 years ago

I'm assuming that the browser attempt was because the cli didn't work. Note: it's not expected to work by itself because it's an API that needs a POST with the manifest in the body.

Based on the call stack for the syntax error, it appears that the response provided was not an expected json response. This could be improved to have a better message for the developers in cases where the response isn't json (which is what the validator returns), but didn't have a problem sending the post.

millerds commented 2 years ago

I'm guessing it's working now though (I don't get the 502 myself).

millerds commented 1 year ago

Add a bug to our backlog to fix the error message.

millerds commented 1 year ago

Update package published now.