OfficeDev / Office-Addin-Scripts

A set of scripts and packages that are consumed in Office add-ins projects.
MIT License
156 stars 99 forks source link

[minor] Add Arch Linux support to certificate installation #805

Closed dorkster100 closed 1 year ago

dorkster100 commented 1 year ago

I did put it as minor, however I have not tested changes on Ubuntu. Hopefully someone else can test, but I will have access to Ubuntu machine in a few days, I can do the tests.

Change Description:

  1. Do these changes impact command syntax of any of the packages? (e.g., add/remove command, add/remove a command parameter, or update required parameters) npm run dev-server or npm run start:web are affected, it now works on Arch Linux properly.

  2. Do these changes impact documentation? (e.g., a tutorial on https://learn.microsoft.com/office/dev/add-ins/overview/office-add-ins) no

Validation/testing performed:

I tested on Arch running npm run dev-server and npm run start:web, it properly verifies and installs the certificate and changes are propagated to Сhromium. Without a need to manually trust these certificates.

Important note: Since the folder structure is different for Arch and Ubuntu, in the Arch version the certificate file name is not defaults.certificateName, but is hardcoded, it can be changed to some_prefix_${defaults.certificateName} if needed.

More info about Linux Certificates https://wiki.archlinux.org/title/User:Grawity/Adding_a_trusted_CA_certificate

Fixes #765

dorkster100 commented 1 year ago

@microsoft-github-policy-service agree

millerds commented 1 year ago

/azurepipelines run

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 1 pipeline(s).
millerds commented 1 year ago

@dorkster100 once you verify on Ubuntu I think we can merge this.

dorkster100 commented 1 year ago

@millerds tested on Ubuntu - works on chromium, not on firefox, but this should be separate issue