OfficeDev / Office-Addin-Scripts

A set of scripts and packages that are consumed in Office add-ins projects.
MIT License
156 stars 99 forks source link

[minor] Add method for setting a "RefreshAddins" registry key. #816

Closed millerds closed 10 months ago

millerds commented 10 months ago

Thank you for your pull request!

Please add '[major]', '[minor]', or [patch] to the title to indicate the impact the change has on the code. Please also provide the following information.


Change Description:

For the json manifest scenario, removing the cache modification call that were added as a workaround and replace it with setting a registry key that will signal to the host app that a refresh of add-ins is needed.  This will work for both sideloading and unacquiring.
  1. Do these changes impact command syntax of any of the packages? (e.g., add/remove command, add/remove a command parameter, or update required parameters) No.

  2. Do these changes impact documentation? (e.g., a tutorial on https://learn.microsoft.com/office/dev/add-ins/overview/office-add-ins) No.

If you answered yes to any of these please do the following:

Include 'Rick-Kirkham' in the review Make sure the README file is correct

Validation/testing performed: Ran automated tests. Create local package that was installed with a test project and used to verify registry was set. This was test in combination with the host change to read the registry value and clear it.

millerds commented 10 months ago

Can I get a review?