search

OfficeDev / Office-Addin-Scripts

A set of scripts and packages that are consumed in Office add-ins projects.
MIT License
152 stars 93 forks source link

[Patch] Fix getInstalledApps.ps1 so it can get correct installed apps #823

Closed pkkj closed 5 months ago

pkkj commented 6 months ago

Change Description:

getInstalledApps.ps1 should look up the installed apps from 32-bit and 64-bit registry path.

  1. Do these changes impact command syntax of any of the packages? (e.g., add/remove command, add/remove a command parameter, or update required parameters) No

  2. Do these changes impact documentation? (e.g., a tutorial on https://learn.microsoft.com/office/dev/add-ins/overview/office-add-ins) No

Validation/testing performed:

The script is validated with its consumer, isAzureCliInstalled() defined configure.ts

millerds commented 6 months ago

/azurepipeline run

azure-pipelines[bot] commented 6 months ago
Azure Pipelines successfully started running 1 pipeline(s).
millerds commented 6 months ago

Thanks for the submission . . . looks like we need to update support of npm to v10. This PR will have to go in after that (PR pending).

millerds commented 5 months ago

/azurepipeline run

azure-pipelines[bot] commented 5 months ago
Azure Pipelines successfully started running 1 pipeline(s).
millerds commented 5 months ago

mac ci machine is having trouble and this fix doesn't apply to mac.