OfficeDev / Office-Addin-Scripts

A set of scripts and packages that are consumed in Office add-ins projects.
MIT License
156 stars 99 forks source link

[minor] Fix minor issue in the configure.ts #833

Closed pkkj closed 7 months ago

pkkj commented 8 months ago

Change Description:

Fix minor issue in the configure.ts.

  1. need to check whether app.DisplayName is truthy because the registry key may return invalid data (like DISPLAYNAME)

  2. logoutAzure is async function so it should be await. Besides, it's OK for hitting error, because if the first login attempt fails, the logout will hit exception.

Do these changes impact command syntax of any of the packages? (e.g., add/remove command, add/remove a command parameter, or update required parameters) No.

Do these changes impact documentation? (e.g., a tutorial on https://learn.microsoft.com/office/dev/add-ins/overview/office-add-ins) No.

Validation/testing performed:

The fix is tested in local machine with the yo office command.

millerds commented 7 months ago

/azurepipelines run

azure-pipelines[bot] commented 7 months ago
Azure Pipelines successfully started running 1 pipeline(s).
millerds commented 7 months ago

/azurepipelines run

azure-pipelines[bot] commented 7 months ago
Azure Pipelines successfully started running 1 pipeline(s).
millerds commented 7 months ago

/azurepipelines run

azure-pipelines[bot] commented 7 months ago
Azure Pipelines successfully started running 1 pipeline(s).