OfficeDev / Office-Addin-Scripts

A set of scripts and packages that are consumed in Office add-ins projects.
MIT License
152 stars 93 forks source link

custom-function-metadata should not use fs in parseTree #837

Closed wandyezj closed 2 months ago

wandyezj commented 4 months ago

Expected behavior

parseTree should be exported independently without references to fs.

i.e. there should be a file called parseTree.ts that only includes parseTree code and does not include generateCustomFunctionMetadata

akrantz commented 4 months ago

I think what is needed here is to rename generate.ts to parseTree.ts, and then move generateCustomFunctionsMetadata() to a new generate.ts file. Then main.ts can export from both generate.ts and parseTree.ts.

millerds commented 4 months ago

Isn't this the main part of what @wandyezj existing PR is trying to do or am I missing something?

wandyezj commented 2 months ago

This was fixed by @akrantz