OfficeDev / Office-Addin-Scripts

A set of scripts and packages that are consumed in Office add-ins projects.
MIT License
152 stars 93 forks source link

[minor] Add handling for new @linkedEntityDataProvider and @excludeFromAutoComplete jsdoc tags #843

Closed jeaniehuynh closed 4 months ago

jeaniehuynh commented 4 months ago

Change Description:

This PR adds handling for the new @linkedEntityDataProvider and @excludeFromAutoComplete metadata tags needed for 3P Linked Entities in Excel.
  1. Do these changes impact documentation? (e.g., a tutorial on https://learn.microsoft.com/office/dev/add-ins/overview/office-add-ins) Yes, we need to add documentation for the new tags

If you answered yes to any of these please do the following:

Include 'Rick-Kirkham' in the review Make sure the README file is correct

Validation/testing performed:

Wrote new test cases and confirmed they all pass. Will link NPM package to office-js-api to test everything before checking in.
jeaniehuynh commented 4 months ago

Few quick questions as this is my first change in this repo:

  1. While building/testing, changes were automatically made (office-addin-... version numbers and integrity value) in the package-lock.json file, should I include it in this change?
  2. Should this PR be tagged with minor or major?
  3. How do I add other reviewers?
millerds commented 4 months ago

Few quick questions as this is my first change in this repo:

  1. While building/testing, changes were automatically made (office-addin-... version numbers and integrity value) in the package-lock.json file, should I include it in this change?
  2. Should this PR be tagged with minor or major?
  3. How do I add other reviewers?
  1. Yes, include the updated package-lock.json file.
  2. If it's a breaking change or really large updated then [Major], but if it's a feature small feature add then [Minor]
  3. The gear icon in the reviewers section in the upper right of the PR page allows you to update the reviewers.
akrantz commented 4 months ago

This is a minor change. It does not have any breaking changes.

millerds commented 4 months ago

/azurepipelines run

azure-pipelines[bot] commented 4 months ago
Azure Pipelines successfully started running 1 pipeline(s).
millerds commented 4 months ago

/azurepipelines run

azure-pipelines[bot] commented 4 months ago
Azure Pipelines successfully started running 1 pipeline(s).