search

OfficeDev / Office-Addin-Scripts

A set of scripts and packages that are consumed in Office add-ins projects.
MIT License
152 stars 93 forks source link

[minor] Additional exclude custom function metadata filters #844

Closed jeaniehuynh closed 4 months ago

jeaniehuynh commented 4 months ago

Change Description:

Add a couple more mutually exclusive tags for @linkedEntityDataProvider custom functions.
jeaniehuynh commented 4 months ago

/azurepipelines run

azure-pipelines[bot] commented 4 months ago
Commenter does not have sufficient privileges for PR 844 in repo OfficeDev/Office-Addin-Scripts
millerds commented 4 months ago

/azurepipelines run

azure-pipelines[bot] commented 4 months ago
Azure Pipelines successfully started running 1 pipeline(s).
millerds commented 4 months ago

Why the changes to the package-lock.json files? They seem to be removing things (references to other office-addin-script packages) that shouldn't be.

jeaniehuynh commented 4 months ago

Why the changes to the package-lock.json files? They seem to be removing things (references to other office-addin-script packages) that shouldn't be.

Those were just the changes that autogenerated when I ran the build. That said, I did initially run a build from the root directory first (not just from the custom-functions-metadata package) if that may have caused it? I can revert and rebuild to double check.

akrantz commented 4 months ago

When I looked at the package lock files, it pulled in the minor dependent package changes which happen. It's not the build but "npm install" at the root and the associated "lerna bootstrap" that is triggered which updates these. It's also fine to not add them.

millerds commented 4 months ago

/azurepipelines run

azure-pipelines[bot] commented 4 months ago
Azure Pipelines successfully started running 1 pipeline(s).