OfficeDev / Office-Addin-Scripts

A set of scripts and packages that are consumed in Office add-ins projects.
MIT License
152 stars 93 forks source link

[Major] Update packages in eslint-plugin-office-addins for updated typescript support #849

Closed millerds closed 2 months ago

millerds commented 3 months ago

Thank you for your pull request!

Please add '[major]', '[minor]', or [patch] to the title to indicate the impact the change has on the code. Please also provide the following information.


Change Description: Projects that use typescript 5 will show a warning when running our linter that certain libraries are not compatible with typescript 5. One of those cases is the custom linter rules where we see package dependencies getting a little stale. This will update all of those dependencies and then make matching code changes for those major version updates.

  1. Do these changes impact command syntax of any of the packages? (e.g., add/remove command, add/remove a command parameter, or update required parameters) No.

  2. Do these changes impact documentation? (e.g., a tutorial on https://learn.microsoft.com/office/dev/add-ins/overview/office-add-ins) No.

If you answered yes to any of these please do the following:

Include 'Rick-Kirkham' in the review Make sure the README file is correct

Validation/testing performed: Ran the automated tests for the linter rules. Built and ran automated test for the entire repo. Note that I wasn't able to test rule packages through test app . . . office-addin-lint couldn't get the updated plugin package even when intalled or linked.