OfficeDev / Office-Addin-Scripts

A set of scripts and packages that are consumed in Office add-ins projects.
MIT License
156 stars 99 forks source link

[patch] Return object from calls to load() #861

Closed greysteil closed 5 months ago

greysteil commented 5 months ago

Change Description:

Aligns return value for load with that used in production (i.e., return the object).

  1. Do these changes impact command syntax of any of the packages? (e.g., add/remove command, add/remove a command parameter, or update required parameters)

No.

  1. Do these changes impact documentation? (e.g., a tutorial on https://learn.microsoft.com/office/dev/add-ins/overview/office-add-ins)

No.

If you answered yes to any of these please do the following:

Include 'Rick-Kirkham' in the review Make sure the README file is correct

Validation/testing performed:

Wrote a test. Tested manually

greysteil commented 5 months ago

@millerds looks like you're the most active merging PRs. This is a tiny change, but brings the mocks into better alignment with the real API. Hopefully it's an easy review, but let me know if anything's unclear. :octocat:

millerds commented 5 months ago

/azurepipelines run

azure-pipelines[bot] commented 5 months ago
Azure Pipelines successfully started running 1 pipeline(s).
millerds commented 5 months ago

Thanks for your contribution!