search

OfficeDev / Office-Addin-Scripts

A set of scripts and packages that are consumed in Office add-ins projects.
MIT License
160 stars 100 forks source link

User/adrians/add expiration date to sso #863

Closed Adrian-MSFT closed 6 months ago

Adrian-MSFT commented 6 months ago

Thank you for your pull request!

Please add '[major]', '[minor]', or [patch] to the title to indicate the impact the change has on the code. Please also provide the following information.

Change Description:

Updated the office-addin-sso configure command to include an optional parameter [secret-ttl] that takes the time to live for the secret used in the Azure app registration, in days. Default is 60 days.

  1. Do these changes impact command syntax of any of the packages? (e.g., add/remove command, add/remove a command parameter, or update required parameters) Added parameter to office-addin-sso configure command. [secret-ttl]: takes the time to live for the secret used in the Azure app registration, in days. Default is 60 days.

  2. Do these changes impact documentation? (e.g., a tutorial on https://learn.microsoft.com/office/dev/add-ins/overview/office-add-ins)

    [secret-ttl]: takes the time to live for the secret used in the Azure app registration, in days. Default is 60 days.

If you answered yes to any of these please do the following:

Include 'Rick-Kirkham' in the review Make sure the README file is correct

Validation/testing performed:

Tested with no input for new parameter, bad input (not a number), and a valid input
millerds commented 6 months ago

Also make sure you sync master and merge.