search

OfficeDev / Office-Addin-Scripts

A set of scripts and packages that are consumed in Office add-ins projects.
MIT License
159 stars 100 forks source link

[minor] Add @capturesCallingObject tag handling #883

Closed legutieMSFT closed 2 months ago

legutieMSFT commented 3 months ago

Thank you for your pull request!

Please add '[major]', '[minor]', or [patch] to the title to indicate the impact the change has on the code. Please also provide the following information.

Change Description:

Handle @capturesCallingObject metadata tag for Excel javascript custom functions

  1. Do these changes impact command syntax of any of the packages? (e.g., add/remove command, add/remove a command parameter, or update required parameters) No

  2. Do these changes impact documentation? (e.g., a tutorial on https://learn.microsoft.com/office/dev/add-ins/overview/office-add-ins) Yes, but will be handled separately to indicate what the flag means

If you answered yes to any of these please do the following:

Include 'Rick-Kirkham' in the review Make sure the README file is correct

Validation/testing performed:

Will validate it works with scriptlab in excel
legutieMSFT commented 3 months ago

@microsoft-github-policy-service agree company="Microsoft"

@microsoft-github-policy-service agree company="Microsoft"

akrantz commented 3 months ago

I will approve to unblock this PR. There's still an opportunity to help the developer by validating that they have a parameter for the calling object and it is of an appropriate type.