Adrian-MSFT
commented
1 month ago I think this is ok, however, would it be possible to break up these huge PRs in the future for ease of reviewing? Though, I realize, it may not always be possible
(I started looking at this earlier today and noticed a lot of these were spacing changes, for example)
Change Description: We are required to use a pipeline template as a base for security purposes. This updates the pipeline files to do so, but this also added the requirement to be able to run the linter at the monorepo root instead of separately for each project which also requires a shared tsconfig file at the root and some package updates. All this added up to some standardization between project, build changes, and many linter fixes. Nothing should be functionally different despite the many changes . . . but verification will be needed.
Should do a major version bump to cover the updated tsconfig building which updated some properties for some packages.
Do these changes impact command syntax of any of the packages? (e.g., add/remove command, add/remove a command parameter, or update required parameters) No.
Do these changes impact documentation? (e.g., a tutorial on https://learn.microsoft.com/office/dev/add-ins/overview/office-add-ins) No.
If you answered yes to any of these please do the following:
Validation/testing performed: Ran the linter, ran the build, ran the automated tests, and used the branch to verify the pipeline changes passed.