search

OfficeDev / Office-Addin-TaskPane-Angular

Template to get start started writing a TaskPane Office Add-in for the Angular framework using TypeScript
Other
14 stars 19 forks source link

Update sideload-msg #107

Closed ElizabethSamuel-MSFT closed 1 year ago

ElizabethSamuel-MSFT commented 1 year ago

Thank you for your pull request! Please provide the following information.

Change Description:

Link to sideload article. Also fix minor typo

  1. Do these changes impact any npm scripts commands (in package.json)? (e.g., running 'npm run start') If Yes, briefly describe what is impacted.

  2. Do these changes impact VS Code debugging options (launch.json)? If Yes, briefly describe what is impacted.

  3. Do these changes impact template output? (e.g., add/remove file, update file location, update file contents) If Yes, briefly describe what is impacted.

  4. Do these changes impact documentation? (e.g., a tutorial on https://docs.microsoft.com/en-us/office/dev/add-ins/overview/office-add-ins) If Yes, briefly describe what is impacted.

If you answered yes to any of these please do the following:

Include 'Rick-Kirkham' in the review Make sure the README file is correct

Validation/testing performed:

Describe manual testing done.
millerds commented 1 year ago

/azurepipelines run

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 1 pipeline(s).
millerds commented 1 year ago

@ElizabethSamuel-MSFT is this change going to be done to the other template repos as well?

akrantz commented 1 year ago

Usually changes like this should be make in Office-Addin-TaskPane and then merged across the template repos. Rather than make the change here, make it in Office-Addin-TaskPane.

ElizabethSamuel-MSFT commented 1 year ago

@ElizabethSamuel-MSFT is this change going to be done to the other template repos as well?

Yes, I want to. But I wasn't sure about the process.

ElizabethSamuel-MSFT commented 1 year ago

Usually changes like this should be make in Office-Addin-TaskPane and then merged across the template repos. Rather than make the change here, make it in Office-Addin-TaskPane.

Ok, I'll update there. Are there other repos I should like at to make similar changes?

akrantz commented 1 year ago

Make the same PR in that repo instead of here. You can close this PR once you to that.