search

OfficeDev / Office-Addin-TaskPane-React-JS

Template to get start started writing a TaskPane Office Add-in for the React framework using JavaScript
Other
25 stars 19 forks source link

remove deprecated recommendation extension; fix launch configuration #117

Closed hermanwenhe closed 8 months ago

hermanwenhe commented 8 months ago

Thank you for your pull request! Please provide the following information.

Change Description:

1. Remove the deprecated extension in extension.json.
2. Remove the launch configuration for other hosts in launch.json to fix the F5 fail issue. (When host is not Excel, pressing F5 will fail since the default configuration in launch.json is Excel Desktop Chrominum.

  1. Do these changes impact any npm scripts commands (in package.json)? (e.g., running 'npm run start') No

  2. Do these changes impact VS Code debugging options (launch.json)? Yes. Only keep launch configuration for current hosts.

  3. Do these changes impact template output? (e.g., add/remove file, update file location, update file contents) No

  4. Do these changes impact documentation? (e.g., a tutorial on https://docs.microsoft.com/en-us/office/dev/add-ins/overview/office-add-ins) No

If you answered yes to any of these please do the following:

Include 'Rick-Kirkham' in the review Make sure the README file is correct

Validation/testing performed:

Manual test with different hosts.
millerds commented 8 months ago

/azurepipelines run

azure-pipelines[bot] commented 8 months ago
Azure Pipelines successfully started running 1 pipeline(s).