OfficeDev / Office-Addin-TaskPane-React-JS

Template to get start started writing a TaskPane Office Add-in for the React framework using JavaScript
Other
25 stars 19 forks source link

Move manifest image prep from code to webpack #71

Closed millerds closed 3 years ago

millerds commented 3 years ago

Currently there are a bunch of import statements for the icon.png images in the .ts files, but the files and the html don't reference those images at all. The references to them are in the manifest.xml files. Webpack doesn't get the resources referenced in the XML like it does in the typescript, javascript, and html and so those were added so that webpack would have those images in the deployment location.

At first glance it's not clear why the import statements were needed and it caused some challenges when making unit tests. The import statements were modified to allow for the unit tests, but this ended up breaking the manifest references (hidden by cache hits). In order to accommodate the unit tests, make sure the images are there for the manifest, and remove potential code confusion this change moves the responsibility of copying the image files to the webpack config file instead of the code files.