OfficeDev / Office-Addin-TaskPane-React

Template to get start started writing a TaskPane Office Add-in for the React framework using TypeScript
Other
59 stars 34 forks source link

Merge office addin taskpane #10

Closed TCourtneyOwen closed 5 years ago

TCourtneyOwen commented 5 years ago

I removed a couple failing builds from the pipeline - going to close and re-open PR to see if that kickstarts the CI pipeline again. I am guessing no but worth a shot

TCourtneyOwen commented 5 years ago

that did in fact kickstart the pipeline

akrantz commented 5 years ago

I wonder if it might be based on whether the branch is up-to-date with master or not. Did pushing the last commit to merge master not kick it off, and it only got kicked off after close and reopen of the PR?

akrantz commented 5 years ago

is it kicking of a build if another commit is pushed?

TCourtneyOwen commented 5 years ago

It should have – there’s definitely something not right here

From: Adam Krantz notifications@github.com Sent: Wednesday, April 24, 2019 3:35 PM To: OfficeDev/Office-Addin-TaskPane-React Office-Addin-TaskPane-React@noreply.github.com Cc: Courtney Owen cowen@microsoft.com; State change state_change@noreply.github.com Subject: Re: [OfficeDev/Office-Addin-TaskPane-React] Merge office addin taskpane (#10)

is it kicking of a build if another commit is pushed?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FOfficeDev%2FOffice-Addin-TaskPane-React%2Fpull%2F10%23issuecomment-486453147&data=01%7C01%7Ccowen%40microsoft.com%7C8dbd74e854db42a08d4e08d6c9051a9d%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=iikeckZc5F7ff%2FwsOkb%2FC8z1EVa9NL2FjXz70MXwWPA%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJCRIFOORH3XZFQ3FIUQSKLPSDOBXANCNFSM4HIGZVXA&data=01%7C01%7Ccowen%40microsoft.com%7C8dbd74e854db42a08d4e08d6c9051a9d%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=N03rlDsNUpDigx%2F7nKwEvj2OBeipc2jogdv61568Wso%3D&reserved=0.