search

OfficeDev / Office-Addin-TaskPane-React

Template to get start started writing a TaskPane Office Add-in for the React framework using TypeScript
Other
54 stars 35 forks source link

Add children declaration to remove eventual linting error #101

Closed SeanKilleen closed 1 year ago

SeanKilleen commented 1 year ago

Resolves https://github.com/OfficeDev/generator-office/issues/730. Following instructions provided by @millerds there.

Thank you for your pull request! Please provide the following information.

Change Description:

When generating the TaskPane React TS app, `npm run lint` fails out of the box due to a missing `children` on the props interface. This allows for linting to be successful.
  1. Do these changes impact any npm scripts commands (in package.json)? (e.g., running 'npm run start') If Yes, briefly describe what is impacted.

No

  1. Do these changes impact VS Code debugging options (launch.json)? If Yes, briefly describe what is impacted.

No

  1. Do these changes impact template output? (e.g., add/remove file, update file location, update file contents) If Yes, briefly describe what is impacted.

Yes - A children: any; property is added to the HeroListProps interface.

  1. Do these changes impact documentation? (e.g., a tutorial on https://docs.microsoft.com/en-us/office/dev/add-ins/overview/office-add-ins) If Yes, briefly describe what is impacted.

No

If you answered yes to any of these please do the following:

Include 'Rick-Kirkham' in the review Make sure the README file is correct

CC @Rick-Kirkham / @millerds.

Validation/testing performed:

⚠️ None at this point; this was a prescribed change that was recommended elsewhere. I'm happy to follow a process to test but might need a little guidance as this is a quick change and I haven't engaged with this repo before.

millerds commented 1 year ago

Thanks for the contribution! But . . . I already had this going in (https://github.com/OfficeDev/Office-Addin-TaskPane-React/pull/100#pullrequestreview-1104876488). Should be in the official template the next time we push updates to the yo-office branch.

SeanKilleen commented 1 year ago

Whoops! Sorry I missed that. No worries!