OfficeDev / Office-Addin-TaskPane-React

Template to get start started writing a TaskPane Office Add-in for the React framework using TypeScript
Other
53 stars 34 forks source link

Correct the webpack polyfill entry reference #122

Closed millerds closed 1 year ago

millerds commented 1 year ago

Thank you for your pull request! Please provide the following information.


Change Description: A misspelling was causing the polyfill generation to be incorrect and projects wouldn't work with the IE webview as a result. Corrected the reference to the entries in webpack config and the adjusted a component compatibility problem that was hidden behind that lack of polyfills

  1. Do these changes impact any npm scripts commands (in package.json)? (e.g., running 'npm run start') No.

  2. Do these changes impact VS Code debugging options (launch.json)? No.

  3. Do these changes impact template output? (e.g., add/remove file, update file location, update file contents) No.

  4. Do these changes impact documentation? (e.g., a tutorial on https://docs.microsoft.com/en-us/office/dev/add-ins/overview/office-add-ins) No.

If you answered yes to any of these please do the following:

Include 'Rick-Kirkham' in the review Make sure the README file is correct

Validation/testing performed: Tried resulting changes on a machine running an older version of office that uses the IE webview explicitly.