search

OfficeDev / Office-Addin-TaskPane-React

Template to get start started writing a TaskPane Office Add-in for the React framework using TypeScript
Other
53 stars 34 forks source link

Get shared modification from office-addin-taskpane #140

Closed millerds closed 6 months ago

millerds commented 6 months ago

Thank you for your pull request! Please provide the following information.

Change Description: Merging changes from office-addin-taskpane that apply here as well

  1. Do these changes impact any npm scripts commands (in package.json)? (e.g., running 'npm run start') added a couple of new commands

  2. Do these changes impact VS Code debugging options (launch.json)? No.

  3. Do these changes impact template output? (e.g., add/remove file, update file location, update file contents) Yes. Updates for eventual use with json manifests

  4. Do these changes impact documentation? (e.g., a tutorial on https://docs.microsoft.com/en-us/office/dev/add-ins/overview/office-add-ins) Possibly. It shouldn't yet . . . but once json manifests are supported then documentation will have to account for that.

If you answered yes to any of these please do the following:

Include 'Rick-Kirkham' in the review Make sure the README file is correct

Validation/testing performed: Ran automated tests.

millerds commented 6 months ago

Note . . . this is needed in order to update generator-office to support a single branch for json and xml manifests.

millerds commented 6 months ago

Nothing has changed since approval other then the tests passing (had to fix the CI pipeline image).