search

OfficeDev / Office-Addin-TaskPane-React

Template to get start started writing a TaskPane Office Add-in for the React framework using TypeScript
Other
54 stars 35 forks source link

Improve webpack bundle size #97

Closed millerds closed 7 months ago

millerds commented 2 years ago

Thank you for your pull request! Please provide the following information.

Change Description: Adjusting imports and webpack config to improve bundling output

  1. Do these changes impact any npm scripts commands (in package.json)? (e.g., running 'npm run start') No.

  2. Do these changes impact VS Code debugging options (launch.json)? No.

  3. Do these changes impact template output? (e.g., add/remove file, update file location, update file contents) No.

  4. Do these changes impact documentation? (e.g., a tutorial on https://docs.microsoft.com/en-us/office/dev/add-ins/overview/office-add-ins) No.

If you answered yes to any of these please do the following:

Include 'Rick-Kirkham' in the review Make sure the README file is correct

Validation/testing performed: Ran build and looked and output sizes. Also ran automated tests.

millerds commented 7 months ago

Updated react libraries don't support the tree shaking setup in the PR. This no longer applies, but size still need to be fixed using some other technique.