OfficeDev / Office-Addin-TaskPane

Template to get started writing a TaskPane Office Add-in.
Other
75 stars 44 forks source link

Preinstall convert requred package and keep sign in/out scripts #243

Closed millerds closed 8 months ago

millerds commented 8 months ago

Thank you for your pull request! Please provide the following information.


Change Description: keeping the sign in/out script because everything has to go through the new service now. Adding logging to the npx command to help with error that might arise for customers.

  1. Do these changes impact any npm scripts commands (in package.json)? (e.g., running 'npm run start') Yes. We keep a couple in more scenarios.

  2. Do these changes impact VS Code debugging options (launch.json)? No.

  3. Do these changes impact template output? (e.g., add/remove file, update file location, update file contents) No.

  4. Do these changes impact documentation? (e.g., a tutorial on https://docs.microsoft.com/en-us/office/dev/add-ins/overview/office-add-ins) I don't think so.

If you answered yes to any of these please do the following:

Include 'Rick-Kirkham' in the review Make sure the README file is correct

Validation/testing performed: Ran tests locally and ran convert script locally.