search

OfficeDev / Office-IT-Pro-Deployment-Scripts

A collection of useful PowerShell scripts to make deploying Office 2016 and Office 365 ProPlus easier for IT Pros and administrators. If you have any feature requests or ideas for future scripts please add the idea to the issues list in this repository
http://officedev.github.io/Office-IT-Pro-Deployment-Scripts
MIT License
882 stars 840 forks source link

System.String error. #89

Closed jamiewhitehead closed 7 years ago

jamiewhitehead commented 8 years ago

Hi Russell. First off, thanks for such an awesome script. I ran it in my test lab and all of the ADMX settings came across. However, I did have some GP push items in there that did not get copied over. I did note that there was a couple of system.string errors that occurred that may be related to this.

Method invocation failed because [System.String] does not contain a method named 'RemoveAll' At C:\temp\CopyOfficeGPO2013to2016\Copy-OfficeGPOSettings.ps1:866 char:17

Method invocation failed because [System.String] does not contain a method named 'RemoveAll'. At C:\temp\CopyOfficeGPO2013to2016\Copy-OfficeGPOSettings.ps1:867 char:17

Cheers.

rsmith0906 commented 8 years ago

Thank you for your feedback! We will take a look at the string errors. Can you provide some specifics on the Push items that didn't come over. That would help us to figure out what we are missing.

jamiewhitehead commented 8 years ago

Not a problem. Interestingly, i reran the script with the push items removed and the same error occurred. so it might not be the push items that are a problem. I have attached the reports of the original Source and target policies so you can check out the push items anyway.

GPO_reports.zip

Also, I am a bit intrigued as to why, in this section, $Paths = [string]"$sysvolDir\$domain\Policies{$ID}\User\Registry.pol", "$sysvolDir\$domain\Policies{$ID}\Machine\Registry.pol"; $commentPaths = ("$sysvolDir\$domain\Policies{$ID}\User\comment.cmtx", "$sysvolDir\$domain\Policies{$TargetID}\User\comment.cmtx"), ("$sysvolDir\$domain\Policies{$ID}\Machine\comment.cmtx", "$sysvolDir\$domain\Policies{$TargetID}\Machine\comment.cmtx"); the $ID and $targetID are doubled up for $commentPaths and not for $Paths. The doubling up also does not seem to fit how it the Array elements for $commentPaths is used around line 858 onwards. But i could be competely wrong...

AStigall commented 7 years ago

@jamiewhitehead is this still an issue? Please let us know if we need to dig further into the issue.

AStigall commented 7 years ago

@jamiewhitehead Please let us know if this is still an issue and we can revisit.

jamiewhitehead commented 7 years ago

Hi,

to be honest, I have not used the script for 4 months or so now. It was certainly useful at the time, but most of my customers are on Office 2016 now.

Cheers.

On Sat, Oct 8, 2016 at 5:31 AM, AStigall notifications@github.com wrote:

@jamiewhitehead https://github.com/jamiewhitehead Please let us know if this is still an issue and we can revisit.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OfficeDev/Office-IT-Pro-Deployment-Scripts/issues/89#issuecomment-252327342, or mute the thread https://github.com/notifications/unsubscribe-auth/AQ4ezWsbTq29knCiY7D_kbQnR9hgSrJ9ks5qxpAYgaJpZM4HquZq .