search

OfficeDev / Office-Inspectors-for-Fiddler

Microsoft Office (MAPI, WOPI, and FSSHTTP) inspectors for Fiddler
MIT License
83 stars 55 forks source link

Current FSSHTTPandWOPIFiddlerInspector.dll is not able to parse the upload traffic of any file to OneDrive #59

Closed rreddy-ns closed 2 years ago

rreddy-ns commented 2 years ago

We have captured upload traffic of a xlsx file to OneDrive through excel app. Earlier we could see this traffic can be parsed by FSSHTTPandWOPIFiddlerInspector.dll, but its not able to parse the latest upload traffic. Can you please check the same.

muhashaf commented 2 years ago

Facing the same issue. Any help appreciated.

ChangDu2021 commented 2 years ago

ParserIssue.zip @rreddy-ns @muhashaf I am from Test Suite project team, and I am trying to repro this issue. Could you please help check if they are the issues that you have, please refer to screenshots and #16 #23 #49 #165 #198 #204 in attached traffic. You would be better if you could share your traffic with us. And we are working on it.

image image

rreddy-ns commented 2 years ago

ParserIssue.zip @rreddy-ns @muhashaf I am from Test Suite project team, and I am trying to repro this issue. Could you please help check if they are the issues that you have, please refer to screenshots and #16 #23 #49 #165 #198 #204 in attached traffic. You would be better if you could share your traffic with us. And we are working on it.

image image

@ChangDu2021 Thank you for reply. Here I am attaching the traffic that was failed to be parsed by the inspector. The traffic is partially parsed by the inspector. Some of the metadata got parsed properly. But its failed to parse actual file data. excel.saz.zip

ChangDu2021 commented 2 years ago

@rreddy-ns After checking your attached traffic, I found that there is no any parser error. The data highlighted in blue could be parsed correctly. So what we need to do is to parser the traffic data in red, right? image You mentioned that this traffic could be parsed earlier. Could you give me more detail info about when or which version it worked? It will help us fix the issue quickly. I suspect some updates caused this issue.

And I wanna double check with you, you didn't use any source code to upload a .xlsx file to OneDrive instead of using excel app to save directly. Could you please share the source code if you have?

rreddy-ns commented 2 years ago

@ChangDu2021 Yes the traffic in red part is not parsed properly. We are not using any source code to upload a file to OneDrive. We are using excel app only to upload the files.

What I mean by 'It was working earlier' is, the fiddler inspector was able to parse the upload traffic to older versions of excel app. We do have the old har files that were collected earlier with older versions of excel app and those har files are parsed properly now also. We do not have the version info of older excel app.

I am attaching an old har file that is parsed properly. excelissue.saz.zip

ChangDu2021 commented 2 years ago

@rreddy-ns The reason why the fiddler inspector is not able to parse the upload traffic to new version of excel is that the MS-FSSHTTPB protocol has changed in new version 20211005. It deleted one field and added 3 new fields in section 2.2.2.1.4 Put Changes.

Deleted field - F - Multi-Request Put Hint (1 bit): A bit that specifies to reduce the number of auto coalesces during multi-request put scenarios. If only one request for a Put Changes, this bit is zero.

Added fields - ContentVersionCoherencyCheck (variable): A Binary Item (section 2.2.1.3) which MUST be ignored.<18> Author Logins (variable): A String Item Array (section 2.2.1.14) structure that defines author login information.<19> Reserved (1 byte): MUST be ignored.

And we are working on fiddler inspector update based on new version 20211005. But after done, it was not able to parse the upload traffic to older version of excel, is it okay for you? Do you have any scenarios that it needs to be able to parse the traffic for both older and new version of excel? Please let me know if you have any concerns.

rreddy-ns commented 2 years ago

@ChangDu2021 It good enough if the inspector is able to parse new version of excel data. We can always use the existing fiddler inspector to parse the older version of excel uploads. Thank you for working on fixing the issue.

ChangDu2021 commented 2 years ago

@rreddy-ns The fix has been merged into master branch in below dev repository. Could you please check if it works at your side? If everything works, we will create a PR to product master branch. https://github.com/xian-rong/Office-Inspectors-for-Fiddler/

rreddy-ns commented 2 years ago

@ChangDu2021 I have verified that the new code is able to parse the data as shown in below screenshots. The data element is extracted twice as shown below. You may proceed with your PR to master branch. Thank you for your support.

image image
ChangDu2021 commented 2 years ago

@rreddy-ns Could you please close this issue because this PR has been merged into master branch?

rreddy-ns commented 2 years ago

@ChangDu2021 Sure.