Add support for Visual Studio 2017

OfficeDev / Open-XML-Package-Editor-Power-Tool-for-Visual-Studio

This Power Tool is a Visual Studio add-in that provides an easy way to parse and edit Open Packaging Conventions files, including Word, Excel and PowerPoint documents.

135 stars 50 forks source link

Add support for Visual Studio 2017 #12

Closed bsivanov closed 3 years ago

bsivanov commented 7 years ago

This aims to add support for Visual Studio 2017. Though I tested it on Visual Studio 2012 - 2017, there are parts I am not sure about, so I would like second opinion:

source.extension.vsixmanifest file contained some strange CustomExtension parts, e.g. <CustomExtension Type="Microsoft Office SmartArt Graphic Color Variation">Templates\default.gcsx</CustomExtension> which I've migrated as Assets in the new format: <Asset Type="Microsoft Office SmartArt Graphic Color Variation" d:Source="File" Path="Templates\default.gcsx" /> I am not sure this is the correct format, nor how to test whether the migration is successful.
When opening VSPackage.resx, the resource names are listed as not valid

The resource name '107' is not a valid identifier.

I am not sure why.

Despite these problems, the extension seems to work pretty well. @pugwonk, I count on you for review.

ridomin commented 7 years ago

any plans to submit the VS2017 extension to the marketplace?

bsivanov commented 7 years ago

@ridomin Given that this is not even commented from the repo owners for 3 months, yes.

For now, you can use the version I pre-built locally: https://1drv.ms/u/s!Amp5JXlYDuqQg9dPJRBo0G3OAw7Jdg

Some teammates and me are using it for months without any issues, it's compatible with VS 2012-2017.

BroVic commented 7 years ago

@bsivanov Hi. That link didn't work...

bsivanov commented 7 years ago

This is the correct link: https://1drv.ms/u/s!Amp5JXlYDuqQg9dPJRBo0G3OAw7Jdg, I am sorry.

bsivanov commented 6 years ago

Hello guys, the forked extension with support for Visual Studio 2017/2015/2013/2012 is published here: Open XML Package Editor for Modern Visual Studios

If anyone from Microsoft is reading this - please let me know if there are some problems with the license. I preserved your copyright messages, and my intention is to ease the work of the OpenXML devs, and not to steal users from this project.

I would happily unpublish the extension to avoid clutter, in case someone merge my pull request here.

bsivanov commented 3 years ago

I am closing this as outdated. My fork is gaining traction, if needed I can merge the relevant changes here as well.