DocumentAssembler: Support for Images (#42)

[krembf]

Implementation of feature request to support templated images in Document Assembler.

[msftclas]

All CLA requirements met.

[krembf]

@twsouthwick, @EricWhiteDev I'm not sure, but will that be better if I do merge first, then re-submit the PR? Not sure what is the preferred workflow. Also the unit tests are failing, so I'm assuming it's all related. Please let me know.

[twsouthwick]

I'm not sure what you mean. The failing tests are due to your change AFAIK. The workflow is generally to submit a PR, iterate until everyone is happy and all checks are passing, then we can merge.

[krembf]

@twsouthwick Thanks for reply. Sure, all I meant to say that I should have done merge/rebase from the OfficeDev/Open-Xml-PowerTools vNext into my fork first and then submit the PR. For whatever reason I haven't done the merge before submitting the PR, so now I'm thinking the test are failing because of this.

[twsouthwick]

Ah. Go ahead and merge into your branch and update it here. No need for a new PR. I've enabled squashed merges so it'll all be squashed before merging anyway.

[krembf]

I've made the changes. Luckily, this just was an issue with relative path to images in XML data file, nothing serious. Thanks!

[MalcolmJohnston]

Hi Guys,

Any chance of an update on this one? I pulled @krembf's fork months ago and have been using the code as is (with some minor functional improvements) so I'd love to see this merged so I can add some PRs on top.

Also more generally what can we do to speed up the changes with the project? Cards on the table I'm mainly interested in (and hence have a better knowledge of) Document Assembler but would be happy to help out where possible.

Cheers, Malcolm

[krembf]

Is no news a good news?

[tomjebo]

Closing all PRs as this repo is being archived and will no longer be maintained by Microsoft. The project is licensed for continued use and development by forking to your own repo.