search

OfficeDev / TeamsFx

Developer tools for building Teams apps
Other
427 stars 164 forks source link

fix: fix office addin scaffold flow and question model #11081

Closed jayzhang closed 1 month ago

jayzhang commented 2 months ago

fix: https://msazure.visualstudio.com/Microsoft%20Teams%20Extensibility/_workitems/edit/27179791

github-actions[bot] commented 2 months ago

Fx-core feat commits:

CLI feat commits:

Extension-toolkit feat commits:

SDK feat commits:

SDK React feat commits:

.Net SDK feat commits:

Fx-core fix commits: fix: up d32e3b4f7 fix: test 991d96c30

CLI fix commits:

Extension-toolkit fix commits:

SDK fix commits:

SDK React fix commits:

.Net SDK fix commits:

github-actions[bot] commented 2 months ago

Fx-core feat commits:

CLI feat commits:

Extension-toolkit feat commits:

SDK feat commits:

SDK React feat commits:

.Net SDK feat commits:

Fx-core fix commits: fix: get language option 343357da9 fix: up d32e3b4f7 fix: test 991d96c30

CLI fix commits:

Extension-toolkit fix commits:

SDK fix commits:

SDK React fix commits:

.Net SDK fix commits:

github-actions[bot] commented 2 months ago

Fx-core feat commits:

CLI feat commits:

Extension-toolkit feat commits:

SDK feat commits:

SDK React feat commits:

.Net SDK feat commits:

Fx-core fix commits: fix: get language option 343357da9 fix: up d32e3b4f7 fix: test 991d96c30

CLI fix commits:

Extension-toolkit fix commits:

SDK fix commits:

SDK React fix commits:

.Net SDK fix commits:

github-actions[bot] commented 2 months ago

Fx-core feat commits:

CLI feat commits:

Extension-toolkit feat commits:

SDK feat commits:

SDK React feat commits:

.Net SDK feat commits:

Fx-core fix commits: fix: get language option 343357da9 fix: up d32e3b4f7 fix: test 991d96c30

CLI fix commits:

Extension-toolkit fix commits:

SDK fix commits:

SDK React fix commits:

.Net SDK fix commits:

github-actions[bot] commented 2 months ago

Fx-core feat commits:

CLI feat commits:

Extension-toolkit feat commits:

SDK feat commits:

SDK React feat commits:

.Net SDK feat commits:

Fx-core fix commits: fix: get language option 343357da9 fix: up d32e3b4f7 fix: test 991d96c30

CLI fix commits:

Extension-toolkit fix commits:

SDK fix commits:

SDK React fix commits:

.Net SDK fix commits:

github-actions[bot] commented 2 months ago

Fx-core feat commits:

CLI feat commits:

Extension-toolkit feat commits:

SDK feat commits:

SDK React feat commits:

.Net SDK feat commits:

Fx-core fix commits: fix: get language option 343357da9 fix: up d32e3b4f7 fix: test 991d96c30

CLI fix commits:

Extension-toolkit fix commits:

SDK fix commits:

SDK React fix commits:

.Net SDK fix commits:

github-actions[bot] commented 2 months ago

Fx-core feat commits:

CLI feat commits:

Extension-toolkit feat commits:

SDK feat commits:

SDK React feat commits:

.Net SDK feat commits:

Fx-core fix commits: fix: get language option 343357da9 fix: up d32e3b4f7 fix: test 991d96c30

CLI fix commits:

Extension-toolkit fix commits:

SDK fix commits:

SDK React fix commits:

.Net SDK fix commits:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 92.14286% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 87.23%. Comparing base (bb3a25c) to head (5cde3dc). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11081/graphs/tree.svg?width=650&height=150&src=pr&token=QQX8WVOEC3&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev)](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11081?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev) ```diff @@ Coverage Diff @@ ## main #11081 +/- ## ========================================== + Coverage 87.14% 87.23% +0.08% ========================================== Files 457 456 -1 Lines 27597 27787 +190 Branches 5553 5615 +62 ========================================== + Hits 24049 24239 +190 - Misses 1780 1783 +3 + Partials 1768 1765 -3 ``` | [Files](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11081?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev) | Coverage Δ | | |---|---|---| | [packages/fx-core/src/common/featureFlags.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11081?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvY29tbW9uL2ZlYXR1cmVGbGFncy50cw==) | `97.50% <ø> (-0.12%)` | :arrow_down: | | [...ackages/fx-core/src/component/coordinator/index.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11081?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvY29tcG9uZW50L2Nvb3JkaW5hdG9yL2luZGV4LnRz) | `88.47% <100.00%> (+0.03%)` | :arrow_up: | | [...rc/component/generator/officeXMLAddin/generator.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11081?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvY29tcG9uZW50L2dlbmVyYXRvci9vZmZpY2VYTUxBZGRpbi9nZW5lcmF0b3IudHM=) | `88.46% <100.00%> (-3.38%)` | :arrow_down: | | [...omponent/generator/officeXMLAddin/projectConfig.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11081?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvY29tcG9uZW50L2dlbmVyYXRvci9vZmZpY2VYTUxBZGRpbi9wcm9qZWN0Q29uZmlnLnRz) | `100.00% <100.00%> (+5.55%)` | :arrow_up: | | [...-core/src/question/options/CreateProjectOptions.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11081?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvcXVlc3Rpb24vb3B0aW9ucy9DcmVhdGVQcm9qZWN0T3B0aW9ucy50cw==) | `100.00% <ø> (ø)` | | | [packages/fx-core/src/question/questionNames.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11081?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvcXVlc3Rpb24vcXVlc3Rpb25OYW1lcy50cw==) | `100.00% <ø> (ø)` | | | [...e/src/component/generator/officeAddin/generator.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11081?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvY29tcG9uZW50L2dlbmVyYXRvci9vZmZpY2VBZGRpbi9nZW5lcmF0b3IudHM=) | `96.47% <96.29%> (+1.17%)` | :arrow_up: | | [packages/fx-core/src/question/create.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11081?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvcXVlc3Rpb24vY3JlYXRlLnRz) | `91.88% <86.84%> (+0.02%)` | :arrow_up: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11081/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev)
github-actions[bot] commented 2 months ago

Fx-core feat commits:

CLI feat commits:

Extension-toolkit feat commits:

SDK feat commits:

SDK React feat commits:

.Net SDK feat commits:

Fx-core fix commits: fix: get language option 343357da9 fix: up d32e3b4f7 fix: test 991d96c30

CLI fix commits:

Extension-toolkit fix commits:

SDK fix commits:

SDK React fix commits:

.Net SDK fix commits:

github-actions[bot] commented 2 months ago

Fx-core feat commits:

CLI feat commits:

Extension-toolkit feat commits:

SDK feat commits:

SDK React feat commits:

.Net SDK feat commits:

Fx-core fix commits: fix: get language option 343357da9 fix: up d32e3b4f7 fix: test 991d96c30

CLI fix commits:

Extension-toolkit fix commits:

SDK fix commits:

SDK React fix commits:

.Net SDK fix commits:

github-actions[bot] commented 2 months ago

Fx-core feat commits:

CLI feat commits:

Extension-toolkit feat commits:

SDK feat commits:

SDK React feat commits:

.Net SDK feat commits:

Fx-core fix commits: fix: create question (#11086) 00f3db5ba fix: get language option 343357da9 fix: up d32e3b4f7 fix: test 991d96c30

CLI fix commits:

Extension-toolkit fix commits:

SDK fix commits:

SDK React fix commits:

.Net SDK fix commits:

github-actions[bot] commented 2 months ago

Fx-core feat commits:

CLI feat commits:

Extension-toolkit feat commits:

SDK feat commits:

SDK React feat commits:

.Net SDK feat commits:

Fx-core fix commits: fix: create question (#11086) 00f3db5ba fix: get language option 343357da9 fix: up d32e3b4f7 fix: test 991d96c30

CLI fix commits:

Extension-toolkit fix commits:

SDK fix commits:

SDK React fix commits:

.Net SDK fix commits:

github-actions[bot] commented 2 months ago

Fx-core feat commits:

CLI feat commits:

Extension-toolkit feat commits:

SDK feat commits:

SDK React feat commits:

.Net SDK feat commits:

Fx-core fix commits: fix: create question (#11086) 00f3db5ba fix: get language option 343357da9 fix: up d32e3b4f7 fix: test 991d96c30

CLI fix commits:

Extension-toolkit fix commits:

SDK fix commits:

SDK React fix commits:

.Net SDK fix commits:

github-actions[bot] commented 2 months ago

Fx-core feat commits:

CLI feat commits:

Extension-toolkit feat commits:

SDK feat commits:

SDK React feat commits:

.Net SDK feat commits:

Fx-core fix commits: fix: create question (#11086) 00f3db5ba fix: get language option 343357da9 fix: up d32e3b4f7 fix: test 991d96c30

CLI fix commits:

Extension-toolkit fix commits:

SDK fix commits:

SDK React fix commits:

.Net SDK fix commits:

github-actions[bot] commented 2 months ago

Fx-core feat commits:

CLI feat commits:

Extension-toolkit feat commits:

SDK feat commits:

SDK React feat commits:

.Net SDK feat commits:

Fx-core fix commits: fix: create question (#11086) 00f3db5ba fix: get language option 343357da9 fix: up d32e3b4f7 fix: test 991d96c30

CLI fix commits:

Extension-toolkit fix commits:

SDK fix commits:

SDK React fix commits:

.Net SDK fix commits:

YueLi-MSFT commented 2 months ago

Tested and verified all 4 cases are correct. Case 1: TEAMSFX_OFFICE_ADDIN = false, TEAMSFX_OFFICE_XML_ADDIN = false taskpane and import are verified. Case 2: TEAMSFX_OFFICE_ADDIN = false AND TEAMSFX_OFFICE_XML_ADDIN = true outlook addin taskpane and import, word taskpane. excel taskpane React are verified. Case 3: TEAMSFX_OFFICE_ADDIN = true AND TEAMSFX_OFFICE_XML_ADDIN = true taskpane and import are verified. case 4: TEAMSFX_OFFICE_ADDIN = true AND TEAMSFX_OFFICE_XML_ADDIN = fasle taskpane and import are verified.

github-actions[bot] commented 2 months ago

Fx-core feat commits:

CLI feat commits:

Extension-toolkit feat commits:

SDK feat commits:

SDK React feat commits:

.Net SDK feat commits:

Fx-core fix commits: fix: create question (#11086) 00f3db5ba fix: get language option 343357da9 fix: up d32e3b4f7 fix: test 991d96c30

CLI fix commits:

Extension-toolkit fix commits:

SDK fix commits:

SDK React fix commits:

.Net SDK fix commits: