OfficeDev / TeamsFx

Developer tools for building Teams apps
Other
425 stars 163 forks source link

feat: add error with help link for AAD client secret errors #11188

Closed blackchoey closed 1 month ago

blackchoey commented 1 month ago
  1. add error with help link for AAD client secret errors
  2. Add new-aad-app telemetry to better understand use existing scenario

https://dev.azure.com/msazure/Microsoft%20Teams%20Extensibility/_workitems/edit/27314538 https://dev.azure.com/msazure/Microsoft%20Teams%20Extensibility/_workitems/edit/27314539 https://dev.azure.com/msazure/Microsoft%20Teams%20Extensibility/_workitems/edit/27314624

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 92.30769% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 87.22%. Comparing base (784d957) to head (6afa4ef). Report is 3 commits behind head on dev.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11188/graphs/tree.svg?width=650&height=150&src=pr&token=QQX8WVOEC3&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev)](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11188?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev) ```diff @@ Coverage Diff @@ ## dev #11188 +/- ## ======================================= Coverage 87.21% 87.22% ======================================= Files 453 456 +3 Lines 27565 27654 +89 Branches 5533 5549 +16 ======================================= + Hits 24040 24120 +80 - Misses 1776 1777 +1 - Partials 1749 1757 +8 ``` | [Files](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11188?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev) | Coverage Δ | | |---|---|---| | [...ackages/fx-core/src/component/driver/aad/create.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11188?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvY29tcG9uZW50L2RyaXZlci9hYWQvY3JlYXRlLnRz) | `86.86% <100.00%> (+0.99%)` | :arrow_up: | | [...nt/driver/aad/error/clientSecretNotAllowedError.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11188?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvY29tcG9uZW50L2RyaXZlci9hYWQvZXJyb3IvY2xpZW50U2VjcmV0Tm90QWxsb3dlZEVycm9yLnRz) | `100.00% <100.00%> (ø)` | | | [...driver/aad/error/credentialInvalidLifetimeError.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11188?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvY29tcG9uZW50L2RyaXZlci9hYWQvZXJyb3IvY3JlZGVudGlhbEludmFsaWRMaWZldGltZUVycm9yLnRz) | `100.00% <100.00%> (ø)` | | | [...core/src/component/driver/aad/utility/constants.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11188?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvY29tcG9uZW50L2RyaXZlci9hYWQvdXRpbGl0eS9jb25zdGFudHMudHM=) | `100.00% <100.00%> (ø)` | | | [...e/src/component/driver/aad/utility/aadAppClient.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11188?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvY29tcG9uZW50L2RyaXZlci9hYWQvdXRpbGl0eS9hYWRBcHBDbGllbnQudHM=) | `91.39% <80.00%> (-1.29%)` | :arrow_down: | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11188/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev)