OfficeDev / TeamsFx

Developer tools for building Teams apps
Other
425 stars 163 forks source link

fix: retire error-message #11190

Closed jayzhang closed 1 month ago

jayzhang commented 1 month ago

fix: https://msazure.visualstudio.com/Microsoft%20Teams%20Extensibility/_workitems/edit/27316534

retire error-message, inner-error, error-stack property in telemetry for now and we will use another property name for error-message after we can make sure the content will not contains any 3rd party message.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.15%. Comparing base (861612a) to head (576c1ac).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11190/graphs/tree.svg?width=650&height=150&src=pr&token=QQX8WVOEC3&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev)](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11190?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev) ```diff @@ Coverage Diff @@ ## hotfix/wxp_mar #11190 +/- ## ================================================== - Coverage 87.15% 87.15% -0.01% ================================================== Files 456 456 Lines 27507 27503 -4 Branches 5522 5520 -2 ================================================== - Hits 23974 23970 -4 Misses 1774 1774 Partials 1759 1759 ``` | [Files](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11190?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev) | Coverage Δ | | |---|---|---| | [packages/fx-core/src/common/telemetry.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11190?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvY29tbW9uL3RlbGVtZXRyeS50cw==) | `98.09% <ø> (-0.04%)` | :arrow_down: | | [packages/fx-core/src/error/script.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11190?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvZXJyb3Ivc2NyaXB0LnRz) | `100.00% <ø> (ø)` | |